search

117HD / RLHD

Old School RuneScape GPU renderer with a suite of graphical enhancements.
BSD 2-Clause "Simplified" License
51 stars 44 forks source link

[Suggestion] Add a setting to adjust or turn off shadows on grass? #415

Open korvl38 opened 4 months ago

korvl38 commented 4 months ago

Hi so in areas with long grass like piscatoris the shadows are very strong, with every blade of grass getting shadows its a bit too much contrast for my eyes. I know I could just turn it off but my preference is for HD.

Actually even when shadows are turned off, each grass is still rendered. At some angles it just looks like a million dark spikes all over the floor. Could we please have a small setting to adjust this to our liking? Thanks

Jin-Jiyunsun commented 4 months ago

Could you provide a screenshot of your problem? We already disable most grass from casting shadow.

korvl38 commented 4 months ago

Could you provide a screenshot of your problem? We already disable most grass from casting shadow.

Yes of course. I have turned my shadows off, see the comparison. I think its the shadow on the grass itself, everything looks very "spikey" I hope that makes sense. Note that I am choosing the worst lighting angle to demonstrate the issue, but the grass is very strong compared to SD

I know probably most people don't care but it's very tiring on my eyes. You could have a few levels of detail between SD and the current grass. 2024-04-15_10-32-47 2024-04-15_10-32-35 RuneLite_0ntgK1QoLb

Jin-Jiyunsun commented 4 months ago

I will take a look into a soultion for this but I cant make any guarantees

Jin-Jiyunsun commented 4 months ago

I'll drop a WIP, thoughts?

image

korvl38 commented 4 months ago

@Jin-Jiyunsun thanks for the quick WIP. It's looking much better already. Seems you have AA on when I did not but either way it looks more natural and less strong on each individual grass.

I prefer closer to low resolution for grass but everyone has different taste, what kind of options are you able to add for adjusting grass settings between SD or HD?

Jin-Jiyunsun commented 4 months ago

I'll be attempting to tune it so it just looks good on a single setting, not really within the scope to offer multiple options for things like this. Had a few people give feedback regarding this so I think its worth trying to solve.