search

117HD / RLHD

Old School RuneScape GPU renderer with a suite of graphical enhancements.
BSD 2-Clause "Simplified" License
51 stars 44 forks source link

Vanilla shadows "Prefer in PvM" not working at Grotesque Guardians? #421

Closed korvl38 closed 2 months ago

korvl38 commented 2 months ago

Hi, i hope I'm not misunderstanding here but according to the hover description of Vanilla Shadows, the setting "Prefer in PvM" should retain the circular shadow of the falling rocks which is helpful, but disable the cast shadow of the rocks? That doesn't seem to be working here, it's very difficult to see Jagex's shadow already with HD on but the cast shadows make it worse. Thank you 2024-05-22_16-49-35

aHooder commented 2 months ago

Yep, we should add those. In the first batch, we only included stuff in Chambers of Xeric and Theatre of Blood, if I remember correctly.

korvl38 commented 2 months ago

Thanks a lot! cant wait

aHooder commented 2 months ago

Fixed in https://github.com/117HD/RLHD/commit/f84b1f121a65fc0f9e47787bb40c70d4fa18f0eb, which should be in the next release. I've also changed the behaviour of 'Prefer in PvM' to only hiding HD shadows in specific cases, which currently only includes falling crystals at Olm, and falling rocks at Grotesque Guardians. I have a feeling people who want to disable shadows for bosses too might as well just disable shadows entirely. If it turns out people were actually relying on that behaviour though, I might add another setting for it.

korvl38 commented 2 months ago

Thanks! I think scurrius is another one. I guess people who are serious turn off shadows for bosses or just turn off HD? idk, I'd rather the aesthetics and the rest don't bother me, its just the shadow of falling rocks especially the damage radius at GGs