Closed Acanixz closed 1 month ago
While we did disuses this at the time, I think I remember we left this feature out so it always matched with the OSRS Events, But I could be wrong either way its still a very good PR Good job, lets see what the others think because I don't think it does any harm as long as we have the default to how it is right now
True, I understand that setting the season to the southern hemisphere ends up making events not match the OSRS events, but I decided to add this as my first PR since I was testing another plugin for 3D weather and the theme was not matching, since the default value is set to the original logic, I think there's no harm in this enhancement.
I also don't think there's any harm in providing this option. We should've maybe done it from the start. I wonder though, what's this extra field in model_overrides
for? I'm guessing you saw the one named seasonalTheme
and figured you had to add one for hemispheres too, since it seems to match. I don't think the new option there is needed though, since this seasonalTheme
field is used to limit certain changes to models to only apply when a specific seasonal theme is active. Would you mind removing that part? Either way, thanks for the PR :slightly_smiling_face:
Correct, I guessed it was required in order to work, thinking about it now makes sense why it shouldn't be there, the hemispheres don't directly affect the models, fixed 👍
Edit: oh wait, I messed up the definition, one sec Edit 2: Fixed
Let me know if you want the contributor role in our Discord btw (and what your Discord handle is). I should also mention, if you want to submit other pull requests in the future, it's ideal if you create a new branch for it on your own repo.
Sure, no problem, I'll create branches for future contributions. Also I joined the Discord server, my discord handle is the same as my github username.
Currently the 'Automatic' Seasonal Theme automatically applies the seasons based around the Northern hemisphere, so I added an option that allows the automatic logic to match the southern hemisphere.
Notes: