search

11cafe / comfyui-workspace-manager

A ComfyUI workflows and models management extension to organize and manage all your workflows, models in one place. Seamlessly switch between workflows, as well as import, export workflows, reuse subworkflows, install models, browse your models in a single workspace
MIT License
1.07k stars 50 forks source link

feature request: workflow names as tabtitles #143

Closed Ulf3000 closed 8 months ago

Ulf3000 commented 8 months ago

hi i modded your app.tsx and added this

document.title = ComfyUI - ${curWorkflow.name ?? "Untitled"};

in line 161 in checkIsDirty function..

looks like this grafik

very handy ..

i can mod it myself after each update of course but its a nice feature and would be nice if you implement it in your programming style .. i just put it there becasue getWorkflow(curFlowID.current) is called already and just updating the title on workflow load will be overridden after a while

edit: or maybe even better without "comfyui" ?? grafik

Weixuanf commented 8 months ago

Hi thanks for the great suggestion! We had the same implemented in dev hehe: https://github.com/11cafe/comfyui-workspace-manager/blob/dev/ui/src/App.tsx#L97-L103 we plan to launch it with next version together with multi-browser-tab support! it should be in beta in just a few days! I can probably push a quick commit to main too before the launch!

I also wonder which one is better: "ComfyUI - [workflow-name]" or just "workflow-name" 🤔

It's def a handy feature. Thanks for putting up the demo! Cheers 🍻

Ulf3000 commented 8 months ago

since workflow names can be long, i think without "comfyui -" is better now. the icon is pretty unique and its probabnly best to create a chrome profile just for comfy with just comfy tabs anyways.

Weixuanf commented 8 months ago

the icon is pretty unique

i think this icon only comes with the Custom Scripts plugin, its not default by comfyui 🫠... or not? correct me if I'm wrong!

Ulf3000 commented 8 months ago

the icon is pretty unique

i think this icon only comes with the Custom Scripts plugin, its not default by comfyui 🫠... or not? correct me if I'm wrong!

which script ? does it? i have this little anime cat girl as icon, i think that was there from the get go

if you are at it maybe you could also create an icon from the most recent generated image in each flow for each tab

here this is how Ill setup my "AI Toolbox" from now on (or very similar at least)

grafik

a vertical tab addon where i can see the workflow names. a session manager which can restore the session a few online ai tools which i use and the github links and tutorials and civitai and whatnot. all in their own chrome profile so i dont mix it up with other browsing stuff

Weixuanf commented 8 months ago

woww your setup looks dope my friend! Looks productivity x100! I should get that side bar tabs too 💯 I always find myself overwhelmed by 10000 tabs in my browser

yeah verified again, that golden angel like girl icon is from this scrip: https://github.com/pythongosssss/ComfyUI-Custom-Scripts

without that plugin, it has no favicon

Screenshot 2024-01-25 at 2 46 38 AM

yeah using the thumbnail of the workflow as the favicon is a good idea too! I'll explore that one

Ulf3000 commented 8 months ago

another thing: when i reload a browser session (or just restore a closed tab) comfy will just load the default workflow in each tab .. wouldnt it be possible to save the workflow id to a cookie/localstorage/sessiostorage/whatever and read it on restore and load the right workflows ? im 90% confident thats possible and not even that hard , will try to look into it tommorrow.

EDIT: localstorage does this perfectly. ill try to write a little function , could be problematic to find the right timing so it doesnt get overridden before its read by the function, react is a bit strange with these things .. in vanila javascript implementing this would be a breeze

Weixuanf commented 8 months ago

Hi in the beta version this is solved by adding the workflow id to the url hash, it’s like @.***

So every time you refresh, the tab should reload the right workflow

BTW are u interested in previewing out beta version ? We have some exciting new features! https://github.com/11cafe/comfyui-workspace-manager/tree/main#beta-preview

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.> Sent: Thursday, January 25, 2024 9:46:06 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)

another thing: when i reload a browser session (or just restore a closed tab) comfy will just load the default workflow in each tab .. wouldnt it be possible to save the workflow id to a cookie/localstorage/sessiostorage/whatever and read it on restore and load the right workflows ? im 90% confident thats possible and not even that hard , will try to look into it tommorrow.

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1909208888, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOIFGHZLWRQP3LGBKTTYQG2N5AVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDQOBYHA. You are receiving this because you commented.Message ID: @.***>

Weixuanf commented 8 months ago

If you decided to checkout beta, make sure you make a copy of your current comfyui-workspace-manager folder somewhere else, just in case anything unexpected happens

Get Outlook for iOShttps://aka.ms/o0ukef

From: Weixuan F @.> Sent: Thursday, January 25, 2024 9:57:10 AM To: 11cafe/comfyui-workspace-manager @.>; 11cafe/comfyui-workspace-manager @.> Cc: Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)

Hi in the beta version this is solved by adding the workflow id to the url hash, it’s like @.***

So every time you refresh, the tab should reload the right workflow

BTW are u interested in previewing out beta version ? We have some exciting new features! https://github.com/11cafe/comfyui-workspace-manager/tree/main#beta-preview

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.> Sent: Thursday, January 25, 2024 9:46:06 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)

another thing: when i reload a browser session (or just restore a closed tab) comfy will just load the default workflow in each tab .. wouldnt it be possible to save the workflow id to a cookie/localstorage/sessiostorage/whatever and read it on restore and load the right workflows ? im 90% confident thats possible and not even that hard , will try to look into it tommorrow.

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1909208888, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOIFGHZLWRQP3LGBKTTYQG2N5AVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIYDQOBYHA. You are receiving this because you commented.Message ID: @.***>

Ulf3000 commented 8 months ago

BTW are u interested in previewing out beta version ? We have some exciting new features!

sure! will check it out

Weixuanf commented 8 months ago

Great! Let me know if that works for you!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Mehler @.> Sent: Thursday, January 25, 2024 10:06:25 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] feature request: workflow names as tabtitles (Issue #143)

BTW are u interested in previewing out beta version ? We have some exciting new features!

sure! will check it out

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/143#issuecomment-1909225677, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOPWLOTR33DY4Q7O5Q3YQG42DAVCNFSM6AAAAABCGBXMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGIZDKNRXG4. You are receiving this because you commented.Message ID: @.***>

Ulf3000 commented 8 months ago

ok i tested it , the workflow restores fine when a tab is restored .. but after a browser restart the most recent flow is just loaded into every comfy ui tab. On Chrome

Weixuanf commented 8 months ago

Oh that’s weird. How did you restart the browser? Just closing all windows?

Before and after restart, does your url looks like: http://127.0.0.1:8188/#/workspaceId@c80fc56b-30a1-44bb-b98a-50c6423a405e

If it looks like just "http://127.0.0.1:8188/" then it will load the most recent workflow It has to have the id in the url to load the certain workflow

Weixuanf commented 8 months ago
Screenshot 2024-01-26 at 6 53 24 AM

make sure you clicked this "Open in new tab" button when opening a workflow

Ulf3000 commented 8 months ago

Screenshot 2024-01-26 at 6 53 24 AM make sure you clicked this "Open in new tab" button when opening a workflow

it were only the old tabs from before installing the beta, after closing them and loading new tabs it worked ..

i tested if the string changes on new flow, flow load , restart, restore tab .. seems to work nicely !

one improvement could be that when closing a tab or the browser, it will alert you that the changes are discarded .. i think using the message to ask for saving with yes/no would be nice.

Weixuanf commented 8 months ago

one improvement could be that when closing a tab or the browser, it will alert you that the changes are discarded .. i think using the message to ask for saving with yes/no would be nice.

like this?

Screenshot 2024-01-26 at 9 49 05 PM

I just added this in dev branch, not yet launched ^^

Weixuanf commented 8 months ago

fixed in latest version