search

11cafe / comfyui-workspace-manager

A ComfyUI workflows and models management extension to organize and manage all your workflows, models in one place. Seamlessly switch between workflows, as well as import, export workflows, reuse subworkflows, install models, browse your models in a single workspace
MIT License
1.14k stars 54 forks source link

Beta Issue - Unable to delete type item #153

Open fredlef opened 10 months ago

fredlef commented 10 months ago

In the beta version the top item in the list of workflows cannot be moved to trash. The trash icon changes to open in new tab icon when pointer is placed on it.

Weixuanf commented 10 months ago

oh weird, i can delete it with no problem, what browser are you using? https://youtu.be/4C3-CTm4Pqk

fredlef commented 10 months ago

I'm in Safari on a M3 Macbook

fredlef commented 10 months ago

Just retested in Chrome - ok, back to Safari - now ok. I'll update if it recurs.

Weixuanf commented 10 months ago

oh ok, i just tested safari too, it's prob hided behind the scroll bar.

Screenshot 2024-01-26 at 10 41 25 PM

in general i would suggest to use chrome, bc we mostly test in chrome

fredlef commented 10 months ago

Ok will do - I'll keep an eye out for that.

Really like what I've seen so far. Is the gallery icon being used - opens up a blank page? I didn't see that accessed in the youtube video.

Thanks,

Weixuanf commented 10 months ago

Oh the gallery will only show images when you have generated images using this workflow. Try generating a images with current workflow and click the gallery icon then you should see images in it

Get Outlook for iOShttps://aka.ms/o0ukef

From: fredlef @.> Sent: Saturday, January 27, 2024 6:01:33 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

Ok will do - I'll keep an eye out for that.

Really like what I've seen so far. Is the gallery icon being used - opens up a blank page? I didn't see that accessed in the youtube video.

Thanks,

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/153#issuecomment-1912752721, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOKCRYV3HUPVYTGU7HTYQQRT3AVCNFSM6AAAAABCMCCRU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSG42TENZSGE. You are receiving this because you commented.Message ID: @.***>

Weixuanf commented 10 months ago

Oh great! I'm glad you see beta working well. Did you upgraded from the main branch (launched version)? Is the upgrading ok? (No data loss or anything?)

Get Outlook for iOShttps://aka.ms/o0ukef

From: Weixuan F @.> Sent: Saturday, January 27, 2024 7:41:52 AM To: 11cafe/comfyui-workspace-manager @.>; 11cafe/comfyui-workspace-manager @.> Cc: Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

Oh the gallery will only show images when you have generated images using this workflow. Try generating a images with current workflow and click the gallery icon then you should see images in it

Get Outlook for iOShttps://aka.ms/o0ukef

From: fredlef @.> Sent: Saturday, January 27, 2024 6:01:33 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

Ok will do - I'll keep an eye out for that.

Really like what I've seen so far. Is the gallery icon being used - opens up a blank page? I didn't see that accessed in the youtube video.

Thanks,

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/153#issuecomment-1912752721, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOKCRYV3HUPVYTGU7HTYQQRT3AVCNFSM6AAAAABCMCCRU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSG42TENZSGE. You are receiving this because you commented.Message ID: @.***>

fredlef commented 10 months ago

Yes - Upgraded from the main branch - worked well - no issues. One interesting thing and not sure that it's of any concern but I did start using Chrome. Not all of the workflows that I could see in Safari were evident in Chrome even though they were pointing to the same folder. I imported the couple that were missing and it was working fine.

fredlef commented 10 months ago

I cannot get the gallery to populate under any circumstances.

Thanks

Weixuanf commented 10 months ago

Ohh so after upgrading, the image gallery doesn’t show any images anymore (old images and one ones))? Even when you generated new image and is it will not adding into the gallery?

And one thing to note about new version, the workflow data is stored in your browser storage so if you switch browser (chrome to safari) you may not see all of your workflows. So it's better to stick to one browser only. This design is to reduce the python network calls so read/write will not occupy bandwidth and improve performance.

Get Outlook for iOShttps://aka.ms/o0ukef

From: fredlef @.> Sent: Sunday, January 28, 2024 8:45:48 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

I cannot get the gallery to populate under any circumstances.

Thanks

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/153#issuecomment-1913389770, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOPXDC2YGROQLRQ5ZKLYQWNTZAVCNFSM6AAAAABCMCCRU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGM4DSNZXGA. You are receiving this because you commented.Message ID: @.***>

fredlef commented 10 months ago

I think the gallery issue is related to MacBook. Did not work before or after upgrade. Running the beta on my windows laptop gallery worked before and after upgrade. (Edge browser).

Weixuanf commented 10 months ago

That’s weird. I’m using Mac and the gallery is ok in my MacBook, are you using Save Image node to save the image to your output folder? It can only load images saved to your ComfyUI output folder.

results from preview nodes like Preview Image will not be loaded. Because it’s saving into temp folder and those images will disappear

Get Outlook for iOShttps://aka.ms/o0ukef

From: fredlef @.> Sent: Sunday, January 28, 2024 8:48:20 PM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

I think the gallery issue is related to MacBook. Did not work before or after upgrade. Running the beta on my windows laptop gallery worked before and after upgrade. (Edge browser).

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/153#issuecomment-1913585284, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOLAQNU7RK325G6VDQLYQZCJJAVCNFSM6AAAAABCMCCRU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU4DKMRYGQ. You are receiving this because you commented.Message ID: @.***>

fredlef commented 10 months ago

That must have been it. I added a save node and it's working properly. By the way for sometime I have been wishing there was a away to save the prompt with an image so I really like the gallery - any chance of a folder structure?

Weixuanf commented 10 months ago

Great glad to know you like the new feature! 🥳 You mean you hope to add folders inside the gallery to organize the images? Since these images are stored in your output folder and to a bit hard to manipulate them to folders. but maybe we can enable tags or sub albums for organizing images which don't involve direct manipulation of your disk folders

Get Outlook for iOShttps://aka.ms/o0ukef

From: fredlef @.> Sent: Monday, January 29, 2024 8:07:02 AM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

That must have been it. I added a save node and it's working properly. By the way for sometime I have been wishing there was a away to save the prompt with an image so I really like the gallery - any chance of a folder structure?

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/153#issuecomment-1913770999, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOIRTOC4WIWRLA5TN6TYQ3R2NAVCNFSM6AAAAABCMCCRU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTG43TAOJZHE. You are receiving this because you commented.Message ID: @.***>

fredlef commented 10 months ago

Yes that's right. Or maybe add a field for image tags that is searchable. Or make all fields searchable. Or "show me all pictures from X model" or show me all pictures that have "xxxxx xxxx" string in the prompt.

Weixuanf commented 10 months ago

I see! That makes sense! Thanks for the good suggestion

Get Outlook for iOShttps://aka.ms/o0ukef

From: fredlef @.> Sent: Monday, January 29, 2024 7:11:41 PM To: 11cafe/comfyui-workspace-manager @.> Cc: Weixuan Fu @.>; Comment @.> Subject: Re: [11cafe/comfyui-workspace-manager] Beta Issue - Unable to delete type item (Issue #153)

Yes that's right. Or maybe add a field for image tags that is searchable. Or make all fields searchable. Or "show me all pictures from X model" or show me all pictures that have "xxxxx xxxx" string in the prompt.

— Reply to this email directly, view it on GitHubhttps://github.com/11cafe/comfyui-workspace-manager/issues/153#issuecomment-1914471289, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMEEOKOLOA6XGBXE4DKCYDYQ57W3AVCNFSM6AAAAABCMCCRU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGQ3TCMRYHE. You are receiving this because you commented.Message ID: @.***>