search

11cafe / comfyui-workspace-manager

A ComfyUI workflows and models management extension to organize and manage all your workflows, models in one place. Seamlessly switch between workflows, as well as import, export workflows, reuse subworkflows, install models, browse your models in a single workspace
GNU General Public License v3.0
973 stars 47 forks source link

Various keybindings no longer work #319

Open HaydenReeve opened 5 months ago

HaydenReeve commented 5 months ago

This is a really odd one.

Having this setting set in your options means you can no longer type "S":

image

Not in search, not in prompt nodes, not anywhere...

I also seem to have lost the ability to press "enter" on a prompt node. Only Shift+Enter appears to work now. Nor can I use the "down arrow key" anymore to navigate long prompts.

Might've caught a mid patch here when I pulled the most recent changes this afternoon. Oops.

Weixuanf commented 5 months ago

@Aller05 I think it's related to here, it's matching arrow up/down and preventing default: https://github.com/11cafe/comfyui-workspace-manager/blob/dev/ui/src/topbar/AppIsDirtyEventListener.tsx#L34

Weixuanf commented 5 months ago

https://github.com/11cafe/comfyui-workspace-manager/pull/321/files

should be fixed now, sorry about it 🤦‍♀️

HaydenReeve commented 5 months ago

Don't be sorry, you are doing fantastic work. I've just pulled the latest and all issues with the enter and arrow keys are all fixed.

There is still the hilarious issue where your save workflow hotkey will override any text box input, so you can't type the character S if you have bound save workflow to Shift + s but that's much less inconvenient. I can always change the hotkey.

Thank you again! :)

Weixuanf commented 5 months ago

Don't be sorry, you are doing fantastic work. I've just pulled the latest and all issues with the enter and arrow keys are all fixed.

There is still the hilarious issue where your save workflow hotkey will override any text box input, so you can't type the character S if you have bound save workflow to Shift + s but that's much less inconvenient. I can always change the hotkey.

Thank you again! :)

Yeah because the control+S key binding is occupied by ComfyUI's default save workflow. So we need to think of something else 🤔 maybe alt+S is better?

HaydenReeve commented 5 months ago

It appears that no matter what you change that keybinding to, if it is a manifestation of shift + letter that keybind takes precedence over any text input comfy might be focused on.

So, changing it to shift + D means you can no longer type D etc.

image