search

11ty / 11ty-website

Documentation site for the Eleventy static site generator.
https://www.11ty.dev/
MIT License
467 stars 677 forks source link

JavaScript examples for pagination docs #1668

Closed w0whitaker closed 4 months ago

w0whitaker commented 4 months ago

This PR includes some of the JavaScript examples that are missing from the docs.

  1. Paging an Object
  2. Paginate a global or local data file
  3. Aliasing to a different variable
  4. Paging a Collection

This is my first pull request, so apologies in advance if anything is confusing or wrong. I'm including all the examples for the pagination page in this PR, if it's a better to split them up, I'm happy to correct that.

Snapstromegon commented 4 months ago

Hi @w0whitaker, first of all thanks for your effort and trying to bring your skills to this project.

It seems to me like you reformatted many files in this project without actually changing them with your own formatting opinions. This way this PR is not reviewable (it changes nearly 300 files and adds 8.3k lines and removes 5.7k lines).

This project has the npm run format script to do formatting. Please use that for formatting and in a normal PR only commit the formatting changes in the parts you're actually touching. That way the PR stays small and is easy to review and merge.

Because of the size of this PR, I'd right now recommend that you pull the current master and apply only your changes you actually want to do on there and open a new PR. That way we can avoid having those massive changes in the commit history.

w0whitaker commented 4 months ago

Oh! So sorry. Thanks for the feedback, and I will close this one, fix the formatting, and open a new one.