search

11ty / 11ty-website

Documentation site for the Eleventy static site generator.
https://www.11ty.dev/
MIT License
467 stars 677 forks source link

Nudge Nordhealth logotext and remove unused styling #1702

Closed macbruker closed 1 month ago

macbruker commented 1 month ago

This aims to optically align the Nordhealth logo with the Transloadit logo and remove some unused styles. For flex-grow to take effect, the parent element needs to have display: flex. It is currently display: grid.

Snapstromegon commented 1 month ago

Thanks for imrpoving the styles. I personally think that moving the logo down by 0.375em is too much. It puts the baseline for the text parts on the same line, but to me it feels like it's lower because the logo is lower. To me a value like 0.2em feels more balanced as a middle ground.

Maybe you can test it yourself and respond. If you think a middle ground works at least as good as your alignment, I think we can take a middle ground, otherwise I'm fine merging this PR as is.

macbruker commented 1 month ago

I agree. 0.2em looks even better. I'll update the code 👍