Recognize `.ico` files with a search query

11ty / api-indieweb-avatar

Return an optimized avatar image from a domain name input.

https://v1.indieweb-avatar.11ty.dev/

65 stars 11 forks source link

Open binyamin opened 1 year ago

binyamin commented 1 year ago

Ignore a URL's search query and/or hash segment when checking the favicon's extension.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	063c6a6b2b39101695bbc01179c19f4aca64976a
Latest deploy log	https://app.netlify.com/sites/eleventy-api-indieweb-avatar/deploys/636005b184fcf200087a3eab
Deploy Preview	https://deploy-preview-13--eleventy-api-indieweb-avatar.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zachleat commented 5 months ago

I’m on board with this change but it needs to use the URL API: https://developer.mozilla.org/en-US/docs/Web/API/URL_API

Been bit too many times on string splitting URLs!

(Also sorry I’m so late on this but it looks like the test case no longer falls prey to this issue)

binyamin commented 5 months ago

Should we just skip the test, and instead, refactor the code which checks the URL file extension?