11ty / eleventy-base-blog

A starter repository for a blog web site using the Eleventy static site generator.
https://eleventy-base-blog.netlify.app/
MIT License
1.2k stars 609 forks source link

Should be clear that permalink and excludeFromCollections are at the mercy of downstream logic #173

Open AramZS opened 4 months ago

AramZS commented 4 months ago

I'm trying to figure my way through the eleventy.config.drafts.js plugin and as far as I can tell you're basically replacing the logic downstream of the plugin on the permalink and eleventyExcludeFromCollections properties of every post? I think I have that correct?

The issue is that if that's the approach and any other data file or function touches either of those the logic gets overwritten right? Then it ends up with the draft logic in the plugin never running? That's a pretty easy thing to mess up on, the documentation often prods users to--at the very least--manipulate permalink on eleventyComputed.

Have I got this issue correct? Is this indeed what can happen? If so, I don't think that's very clear in the code and it could likely use some inline comments. I'd be glad to submit a PR if so, but I'm not quite sure I've got the problem I'm seeing locked down and want to double check.