search

11ty / eleventy-plugin-rss

A pack of Eleventy plugins for generating an RSS feed.
https://www.11ty.dev/docs/plugins/rss/
MIT License
92 stars 23 forks source link

Plugin installs eleventy v0.3.1 when using yarn #2

Closed fephil closed 5 years ago

fephil commented 5 years ago

Hi,

When using this plugin with eleventy v0.6.0, v0.3.1 is installed as a dependency as well. Could eleventy either become a peer dependency or the version bumped to ^0.6.0 to prevent the duplication?

Thanks.

zachleat commented 5 years ago

Hey @fephil I was looking at a few gulp plugins to see how they do it and it looks like they put gulp into the devDependencies instead of using peerDependencies. Can you think of any downsides to doing that instead?

zachleat commented 5 years ago

(I did that, 1.0.4 is out now)

fephil commented 5 years ago

This is great, thanks for sorting @zachleat. Have a nice holiday.

zachleat commented 5 years ago

Thanks @fephil, you too!