11ty / eleventy-plugin-rss

A pack of Eleventy plugins for generating an RSS feed.
https://www.11ty.dev/docs/plugins/rss/
MIT License
92 stars 22 forks source link

unable to install eleventy-plugin-rss with v0.12.1 #26

Closed huphtur closed 3 years ago

huphtur commented 3 years ago

Describe the bug Tried to install official RSS plugin after upgrading to v0.12.1 and got some errors.

To Reproduce npm install @11ty/eleventy-plugin-rss --save-dev

Error log

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: 11ty12@1.0.0
npm ERR! Found: @11ty/eleventy@0.12.1
npm ERR! node_modules/@11ty/eleventy
npm ERR!   dev @11ty/eleventy@"^0.12.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @11ty/eleventy@"^0.11.0" from @11ty/eleventy-plugin-rss@1.1.0
npm ERR! node_modules/@11ty/eleventy-plugin-rss
npm ERR!   dev @11ty/eleventy-plugin-rss@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/mappelman/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mappelman/.npm/_logs/2021-03-19T23_58_36_331Z-debug.log

Environment:

Additional context Tested all other official plugins, they all seem to install fine.

daflh commented 3 years ago

I think it's because eleventy-plugin-rss uses Eleventy ^0.11.0 as peer dependency. Meaning that it will only work with Eleventy 0.11.x according to this semver rule.

Maybe we should update the required Eleventy peer dependency to a looser version like the one in this plugin? @zachleat

zachleat commented 3 years ago

Yeah, I agree! I’ll put this up with 1.1.1.

zachleat commented 3 years ago

v1.1.1 has been published!

zachleat commented 3 years ago

I also found it on https://www.11ty.dev/docs/plugins/inclusive-language/ and published a new version there.

Thanks for the report!