search

11ty / eleventy-plugin-rss

A pack of Eleventy plugins for generating an RSS feed.
https://www.11ty.dev/docs/plugins/rss/
MIT License
91 stars 22 forks source link

Compatibility with Eleventy 2.x.x #55

Open j9t opened 1 week ago

j9t commented 1 week ago

When doing a brief test the other week, the latest release seems only compatible with Eleventy 3.0.0 Alpha.

Did I miss something (on the road and well might have!), or is there a path forward here that allows users to keep using the latest version of this plugin with 2.x.x, or until Eleventy 3 is stable?

Right now, the release makes for a pretty inconvenient situation for anyone automating dependency management (e.g., Dependabot, Depfu, and similar PRs can’t be merged).

lyzadanger commented 1 week ago

Same issue here; dependabot update (PR) for this package @2.0.1 breaks build with Eleventy @2.0.1.

zachleat commented 1 week ago

Sorry folks, this is my fault. I should have put the RSS plugin on a prerelease channel.

We’re coming into the final stages before shipping Eleventy Core 3.0 stable and the latest major version of the RSS plugin is only compatible with Eleventy Core 3.0 and above. The 3.0 compatibility was a breaking change (and a major version bump) for the RSS plugin in v2.0.0 and newer.

It should have shown an incompatibility error for you (which is hopefully why you’re here!)

Is dependabot doing something undesirable here with major version bumps in dependencies?

Release notes for RSS plugin v2.0.0: https://github.com/11ty/eleventy-plugin-rss/releases/tag/v2.0.0

j9t commented 1 week ago

Dependabot and Depfu seem to be behaving correctly, in informing about an major update to the RSS plugin. That that requires moving the main dependency (Eleventy) from stable to alpha is not clear, unfortunately, and a tough call even for early adopters :)

For anyone liking to use stable releases and keeping their dependencies up-to-date this isn’t a great situation right now, but it seems that’s belaboring the point :)

frankieroberto commented 1 week ago

Same issue here, on a project which uses a plugin which uses eleventy-plugin-rss - see https://github.com/frankieroberto/nhsnotes/pull/31

I think the root cause of why Dependabot didn't catch this (and you only get the error at build time) is that Eleventy version 3 is only specified in the package.json within "11ty": {"compatibility": ">=3.0.0-alpha.13"}, rather than as an npm dependency (which Dependabot would’ve caught).

Is there any reason for this?