search

11ty / eleventy-plugin-rss

A pack of Eleventy plugins for generating an RSS feed.
https://www.11ty.dev/docs/plugins/rss/
MIT License
92 stars 22 forks source link

Rename? #8

Closed gerwitz closed 3 years ago

gerwitz commented 5 years ago

I've been using this plugin to generate an RSS 2.0 feed, but the date formats here are meant for Atom. So now I have to replace rssDate et al because…they're not RSS compatible?

Unless I misunderstand, it seems this should be eleventy-plugin-atom!

datashaman commented 4 years ago

And the contents aren't properly escaped for XML. You're better off using something like the following plugin to generate the XML properly. It also includes the correct filter for generating RFC2822 dates for RSS.

https://www.npmjs.com/package/eleventy-xml-plugin

Like the author says: ¯\(ツ)/¯

PS: Using JS Date's native toString() or toUTCString method should work for RSS datetimes.

zachleat commented 3 years ago

I agree with you here, I made some pretty big naming mistakes on this plugin.

If we rename it will be a breaking change to fix. Maybe better to alias for awhile, deprecate and remove the terrible names later.

zachleat commented 3 years ago

@datashaman per the escaping question, I believe this is handled by Nunjucks autoescaping feature? https://mozilla.github.io/nunjucks/templating.html#autoescaping

zachleat commented 3 years ago

Removal issue created here: https://github.com/11ty/eleventy-plugin-rss/issues/21

zachleat commented 3 years ago

Reopening for the outstanding question about the Plugin Name

zachleat commented 3 years ago

The remaining work for this we’ll move to https://github.com/11ty/eleventy-plugin-rss/issues/23

zachleat commented 3 weeks ago

23 is shipping with plugin version 2.0.

zachleat commented 3 weeks ago

I did open a full plugin rename in #48, if you’d like to follow along there!