Open cekvenich2 opened 1 year ago
Hi @cekvenich2, first of all I'd like to mention that his probably isn't the right repo for your issue. I think you'd want to make a PR to this repo and folder: https://github.com/11ty/11ty-website/tree/main/src/_data/starters because there are all starters that are also shown on the 11ty website.
Nonetheless I'd like to give some immediate feetback after just taking a first look and without really testing your starter:
setTemplateFormats
, so there's no reason to set htmlTemplateEngine
setLibrary
(also I think this overrides your previous settings)npm init -y
once on an empty dir and take a look at what keys are set there@11ty/eleventy --serve
)indent_style = tab
is the right way to go. Maybe remove the .editorconfig completely from the repoJust to be clear again: This is not to stomp on you, but just what I found to improve while giving it a short look.
@Snapstromegon Thank you so much for the input! I will adjust all and after PR at the right place.
@Snapstromegon Again thank you the time to review :-). I implemented most, but not all as I have reasons. I don't think it is good use of time to go over all that I passed on. But one is using 11ty's reload server: It only works in local host. It does not work when you develop in the cloud, as it does not like ip addresses. So I have to use another reload server. I plan to do a PR to get this kit listed next.
@cekvenich2 I'd recommend taking a look at the dev server docs. You can use the following line to make it listen on all interfaces in your config:
eleventyConfig.setServerOptions({showAllHosts: true});
In my opinion a good cloud development solution should either involve some port forwarding, so you can access remote "local" ports and/or allow you to directly debug/use the remote service.
Nonetheless I think that the default for a starter should be fast, local development, as that's one of the core strength of 11ty (IMO). If you think that a different dev server is core to your starter, that's valid, but should be stated clearly in the readme, as that's a fairly unexpected deviation from the default.
Perfect. Will do. Thank you for all the input, I appreciate it.
(ftw, I do think developing in the cloud w/ VS code in browser is 'the future'. I am doing it and I feel it increased my productivity. Most of the things are the same except VS code is in browser. So when I right click to open terminal, it is some IP. Oh and I did try to use https proxy for the '11ty server's local port' - no joy. Most of the time that works. One day when we can specify IP in 11ty like: https://github.com/tapio/live-server and I'll remove live server. I only use it for dev anyway, for production I use Caddy w/ CDN)).
On Fri, Jan 27, 2023 at 3:54 PM Raphael Höser @.***> wrote:
@cekvenich2 https://github.com/cekvenich2 I'd recommend taking a look at the dev server docs https://www.11ty.dev/docs/dev-server/. You can use the following line to make it listen on all interfaces in your config:
eleventyConfig.setServerOptions({showAllHosts: true});
In my opinion a good cloud development solution should either involve some port forwarding, so you can access remote "local" ports and/or allow you to directly debug/use the remote service.
Nonetheless I think that the default for a starter should be fast, local development, as that's one of the core strength of 11ty (IMO). If you think that a different dev server is core to your starter, that's valid, but should be stated clearly in the readme, as that's a fairly unexpected deviation from the default.
— Reply to this email directly, view it on GitHub https://github.com/11ty/eleventy-plugin-template-languages/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASK4M5HT5W4333CQ7JY6MODWUQ7XXANCNFSM6AAAAAAUCWMSNY . You are receiving this because you were mentioned.Message ID: @.***>
@Snapstromegon I just made the PR. https://github.com/11ty/11ty-website/pull/1536
It has link to a publicly running site, responsive nav, etc. I added a simple 'npm run dev' that works without 3rd party.
Some smaller items remain, I'll get to them soon, but I think it is a nice starter. If there is something 'big', let me know please and I'll get to it.
@cekvenich2 @zachleat I think we can close this issue, since the discussion is not related to 11ty itself.
@cekvenich2 If you want to have an issue for the improvements, I'd recommend moving it to your repo.
Sidenote after looking at your demo:
link rel=preload
or don't preload them at all (IMO especially not via JS). @zachleat has a bunch of really great content regarding font optimization! Just search for "font" here: https://www.zachleat.com/web/@Snapstromegon Yes please! Can you continue to comment, I made a thread on my project, but it's gitlab(github played some games, not w/ me, but others). Just post a comment in a 'issue' I made pretty please: I'll tag you when I do a 'bigger' release for you to glance if you would please.
Briefly touch on some:
(Psst! This Issue should be tagged with template-language:pug
)
https://gitlab.com/cekvenich2/11pug
Happy to get any comments to make my starter kit better :-)