search

11ty / eleventy

A simpler site generator. Transforms a directory of templates (of varying types) into HTML.
https://www.11ty.dev/
MIT License
17.27k stars 495 forks source link

Add Windows to travis-ci builds #353

Closed zachleat closed 5 years ago

zachleat commented 5 years ago

https://blog.travis-ci.com/2018-10-11-windows-early-release

zachleat commented 5 years ago

Windows samples here https://travis-ci.org/11ty/eleventy/builds/478638999

zachleat commented 5 years ago

Make sure https://github.com/11ty/eleventy/pull/381#issuecomment-453758111 is working before this is added.

kleinfreund commented 5 years ago

Maybe we could do something like sorting both expected and actual results.

zachleat commented 5 years ago

Tried this again, looks a bit more straightforward this time: https://travis-ci.org/11ty/eleventy/builds/516470666

kleinfreund commented 5 years ago

The errors are related to the url() function which has some code producing Windows-style path delimiters. This should never happen when dealing with URLs. Should be easy enough to fix. Unfortunately, I no longer have a Windows system available to me to test this. Maybe a fix is possible without by looking at the Travis results.

zachleat commented 5 years ago

Looks like this was fixed in #486! Thank you @AndrewAsquith!!

zachleat commented 5 years ago

Heck yeah https://travis-ci.org/11ty/eleventy/builds/518844789

kleinfreund commented 5 years ago

Heck yeah indeed!