search

1200wd / 1200wd_addons

Odoo Apps by 1200 Web Development
Other
1 stars 8 forks source link

8.0 4801 transsmart analysis #69

Closed daramousk closed 2 years ago

daramousk commented 6 years ago

@NL66278 Two things here:

1) The prebooking functionality has to be removed 2) Anything that took place on sale.order has been removed.

daramousk commented 6 years ago

@NL66278 This has not been tested yet because I will port this to v2 and that is were the tests will take place. Basically I am concerned with you reviewing the parts of code that I have removed if they are correct and if there is something else to remove.

daramousk commented 6 years ago

@NL66278 More commits added that remove extra clutter. Now I will start porting this to v2

daramousk commented 6 years ago

@NL66278 This is a WIP, I will notify when to review soon.

daramousk commented 5 years ago

@NL66278 I need another review here before I start writing migration scripts, this module contains the whole sprint7. Let me know when I can have this.

CC: @lfreeke

NL66278 commented 5 years ago

@daramousk What I am missing is some README.rst to explain the general concepts and comments in the coding making clear what it does. For instance you add a reference to product.template to res.partner with the name package_type_id. What is this? Why is it on partner? Ofcourse I could grab the transsmart API documentation and extensively study that, but some explanation in the code would really help.

daramousk commented 5 years ago

@NL66278 I had mistakenly force pushed an empty commit, see now for a full readme.