search

1200wd / 1200wd_addons

Odoo Apps by 1200 Web Development
Other
1 stars 8 forks source link

8.0 4223 statement match journal channel #72

Closed daramousk closed 5 years ago

daramousk commented 5 years ago

@NL66278 get_proper_channel is used in the rules like this '@get_proper_channel@` When this is deployed I have to modify some rules on production by adding and extra clause that contains this call

daramousk commented 5 years ago

@NL66278 Check my latest changes, I have created two migration functions that take care of everything

NL66278 commented 5 years ago

@daramousk Looks great. From a philosophical point of view the migration of the pure Ari stuff might go into an Ari module, but I guess this is used by Ari only anyway.

Did you test the migration and the working of the rules after migration? In that case I could merge

daramousk commented 5 years ago

@NL66278 I seems that in order for this to execute I have to remove set noupdate="0" once and then revert it after the migration happens because it does not run when it is 1. Other than that the rules seem to run ok. Still I will ask for client to test again

NL66278 commented 5 years ago

@daramousk I was already a bit afraid of the noupdate flag.

You might leave out the noupdate flag altogether, but where you search for journals to update include the criterium that sales_channel must not already have been set. (To prevent phony updates).

daramousk commented 5 years ago

@NL66278 Well the no update flag should have worked properly. In any case I have removed it and added the extra case in the domain.

NL66278 commented 5 years ago

OK, now just waiting for positive test results.

daramousk commented 5 years ago

@NL66278 Client tested and approved. See the relevant ticket.