search

1200wd / bitcoinlib

Bitcoin and other Cryptocurrencies Library for Python. Includes a fully functional wallet, Mnemonic key generation and management and connection with various service providers to receive and send blockchain and transaction information.
http://bitcoinlib.readthedocs.io/
GNU General Public License v3.0
604 stars 200 forks source link

Defer the creation of the config directory until requested #395

Closed HoverHell closed 4 months ago

mccwdev commented 4 months ago

Tried to merge this to test, but couldn't get it to work. Database is set to None / test/None when unittesting, and logs are send to stdout. Also logs username / password when used in database uri

HoverHell commented 4 months ago

I've rebased these changes onto the current master. Tests seem to mostly work. (Edit: local tests; I'll look into CI tests later)

logs username / password when used in database uri

Fixed that.

None / test/None when unittesting

Which tests cause that?

mccwdev commented 4 months ago

Which tests cause that?

Some local test with python -m unittest. Could also be a local problem, I test it again with the fixed PR.

mccwdev commented 4 months ago

Sorry, I've reverted the PR, was not able to get it working.

Not all global variables where available everywhere resulting in creating of database 'None' and not being able to find local files, as you can see for instance in https://github.com/1200wd/bitcoinlib/actions/runs/9366996897