search

1234- / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
1 stars 0 forks source link

Prevent high server and client (browser) load when showing diffs #349

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. View a comparison of two refs ("compare" view) or view a commit comparison 
to the parent commit ("commitdiff" view).
2. If a ref or the diff itself have modifications of lots of files and content 
(I can already see problems with modifications of around 100 files) as a user 
you find your browser stumbling (long loading time, high load an memory usage). 
On the server side I also detected OOMEs one time.

What is the expected output? What do you see instead?
I surely want to see the diffs between all files regarded. But instead of 
loading all files and diff contents at once it would probably be a good 
solution to first load only part of files and contents. For example only first 
ten files and content. the others should be expandable and therefore be loaded 
when manually triggered.

What version of the product are you using? On what operating system?
1.3.1; debian; on client side problems seen with chrome and firefox in 
different versions.

Me as a developer am of the opinion that one should not compare hundreds and 
more files an their contents and complain that my tool is breaking. There are 
definitely limits of ressource processing products. But in GitBlit and its very 
user friendly GUI I would like to have the certainty that the server won't let 
himself be distracted by such a request.

Maybe there has already been a change in v1.4?

Original issue reported on code.google.com by stephan....@googlemail.com on 5 Dec 2013 at 11:09

GoogleCodeExporter commented 9 years ago 
There have been no improvements related to diffs in 1.4.  I don't expect to 
think about this for the 1.4 release.

Original comment by James.Mo...@gmail.com on 5 Dec 2013 at 1:12

GoogleCodeExporter commented 9 years ago 
acknowledged

Original comment by stephan....@googlemail.com on 2 Jan 2014 at 3:43

GoogleCodeExporter commented 9 years ago 
A contributor has overhauled the diff page to be more performant. This 
improvement is queued for 1.7.0.

Original comment by James.Mo...@gmail.com on 11 Nov 2014 at 3:18