1234- / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
1 stars 0 forks source link

Commit Log Graph incorrect #597

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use a git with multiple branches and mergres
2. Show the commit log

Expected is a graph that corresponds to the commits shown in the commit list. 
The generated output merges etc. are incorrect in the graph. For example, there 
are no merge commits in the graph but in the commit list and vice versa.

Running gitblit as gerrit plugin in gerrit 2.11.

As far as I understand the logic, it seems that the PlotWalk used in the graph 
servlet produces a different order of commits than the JGitUtil.getRevLog() 
function. This might be due to differing setup of the jgit RevWalk objects, 
e.g., the walker used for the commit log is initialized with an 
setUninterresting(...) what changes the walker to topo order and the PlotWalk 
is not.

Original issue reported on code.google.com by alex.w...@gmx.net on 10 Jun 2015 at 12:30

GoogleCodeExporter commented 9 years ago
Hmm.  I haven't observed that myself.  Maybe you'd be interested in playing 
around with the code and opening a pull request to improve it.

Original comment by James.Mo...@gmail.com on 11 Jun 2015 at 4:07

GoogleCodeExporter commented 9 years ago
After some more investigation it seems the problem is not the sorting of the 
commits. However, when going to the second page of a history with multiple 
branches the graph is rendered for the history of the parent of the last commit 
on the first page and possibly does not contain commits that are visible in the 
commit log.

Original comment by alex.w...@gmx.net on 15 Jun 2015 at 11:21

GoogleCodeExporter commented 9 years ago
Yeah, I had forgotten about that.  Would you be interested in submitting a PR 
to address the design flaw?

Original comment by James.Mo...@gmail.com on 28 Jun 2015 at 1:30