search

123oro321 / sereneseasonsfix

MIT License
2 stars 3 forks source link

Synchronization method does not factor in starting subseason #8

Open Car-repo opened 5 days ago

Car-repo commented 5 days ago

Running the latest Fix 1.1.0.1 for Serene Seasons 1.16.5-4.0.1.130.

I play starting in late spring with 4 day long subseasons. Currently on the 10th MC day, "/season time sync" sets calendar to late spring, whereas the correct season should be around mid summer. Clearly subseason length is considered, but no the initial subseason.

I have to add that I downloaded the Fix just yesterday night. Havent test it extensively, however, I still experience some 20-30 tick divergence upon reloading a world, which the mod should have fixed?

123oro321 commented 5 days ago

Hey. Currently sync sets season time to world time without taking into consideration the starting season from server configuration, I will add it to my to do list. For now you should change the season with the other commands, /season time add 24d will skip to next season (with default season length), or use /season set SEASON. About the divergence, please confirm with /season time info the delta is changing after loading the world. Are there other mods? Is it happening always when you load the world?

Car-repo commented 5 days ago

Yes, delta changes whenever I load a world (regardless of whether I quit to desktop or just to main menu) even when only both Seasons mods are enabled. In fact, newly created worlds are already desynced for me.

At least your mod presents a much needed way to properly synchronize clocks, great!

123oro321 commented 1 day ago

I am trying to reproduce the issue, I set the configuration to start at a different season and tried unloading/reloading the world few times. The delta stays the same no matter what I do. Please let me know if you are using other mods or running the commands from different dimensions (by default only the overworld has seasons, nether/end's season time is fixed so the delta will naturally increase there)