Closed eduardomb08 closed 2 years ago
Hi Tony,
No big deal, I'm just curious as of why I don't show under Contributors.. I don't contribute much to anything, so I may be missing something... (PS: I don't mind if you want to keep the list short with just main contributors).
Thanks and Best Regards,
Eduardo Monteiro de Barros
From: Tony Redmond @.> Sent: Wednesday, July 27, 2022 06:12 To: 12Knocksinna/Office365itpros @.> Cc: Eduardo Monteiro de Barros @.>; Author @.> Subject: Re: [12Knocksinna/Office365itpros] Fixed nextLink and made recursive to get all sub-folders and files (PR #54)
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F12Knocksinna%2FOffice365itpros%2Fpull%2F54%23event-7071610346&data=05%7C01%7C%7C9a950a9a2fe34e6dbbf008da6fb88372%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637945135507484605%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Kov0LXuHDB9U%2Ftrn1zORmhI94ABv7KV339A5E9Dqi0E%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACZTD54UCGVPXFNFBVPRQLTVWEDQ3ANCNFSM54S7ASPQ&data=05%7C01%7C%7C9a950a9a2fe34e6dbbf008da6fb88372%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637945135507484605%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LrtmfHfRyXkbwiV3Cre%2BIwMt1P8LZG6QXynXmFsSAMs%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
I didn't do anything to update or refine the contributor list. I leave that to GitHub to figure out. I'm sure you'll turn up eventually. It might be a background process that needs to fire up to update the list.
Sounds good! Thanks!
Great stuff in the repo, btw!
Best Regards,
Eduardo Monteiro de Barros
From: Tony Redmond @.> Sent: Wednesday, July 27, 2022 11:19 To: 12Knocksinna/Office365itpros @.> Cc: Eduardo Monteiro de Barros @.>; Author @.> Subject: Re: [12Knocksinna/Office365itpros] Fixed nextLink and made recursive to get all sub-folders and files (PR #54)
I didn't do anything to update or refine the contributor list. I leave that to GitHub to figure out. I'm sure you'll turn up eventually. It might be a background process that needs to fire up to update the list.
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F12Knocksinna%2FOffice365itpros%2Fpull%2F54%23issuecomment-1196898619&data=05%7C01%7C%7C7363b77ae85c4e42e26908da6fe36dd3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637945319853418848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FFyHoE7LybjOM8gpk2ZMcVq4h6ke%2BhkGa5ZajmWgu1g%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACZTD55772VTOH6J6N3HY7LVWFHQZANCNFSM54S7ASPQ&data=05%7C01%7C%7C7363b77ae85c4e42e26908da6fe36dd3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637945319853418848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VRmDL44MDVEVA6BKgBMrTWyy5Yl70eAvNUjFO8DItiM%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
FYI... I found out the reason it's not showing... I did the commit with my work e-mail and it must be the same e-mail in the GitHub account for it to show the contributor.
[cid:6b3643ad-9a82-4442-9806-bd16f24da2b3]
Best Regards,
Eduardo Monteiro de Barros
From: Tony Redmond @.> Sent: Wednesday, July 27, 2022 11:19 To: 12Knocksinna/Office365itpros @.> Cc: Eduardo Monteiro de Barros @.>; Author @.> Subject: Re: [12Knocksinna/Office365itpros] Fixed nextLink and made recursive to get all sub-folders and files (PR #54)
I didn't do anything to update or refine the contributor list. I leave that to GitHub to figure out. I'm sure you'll turn up eventually. It might be a background process that needs to fire up to update the list.
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F12Knocksinna%2FOffice365itpros%2Fpull%2F54%23issuecomment-1196898619&data=05%7C01%7C%7C7363b77ae85c4e42e26908da6fe36dd3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637945319853418848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FFyHoE7LybjOM8gpk2ZMcVq4h6ke%2BhkGa5ZajmWgu1g%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACZTD55772VTOH6J6N3HY7LVWFHQZANCNFSM54S7ASPQ&data=05%7C01%7C%7C7363b77ae85c4e42e26908da6fe36dd3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637945319853418848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VRmDL44MDVEVA6BKgBMrTWyy5Yl70eAvNUjFO8DItiM%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
Well, go ahead and make another small change and commit using whatever address does the right thing and you'll get that status.
I also added logic to select the drive instead of always going with the default one.