1337-server / automatic-ripping-machine

Automatic Ripping Machine (ARM) Scripts
https://b3n.org/automatic-ripping-machine
MIT License
52 stars 15 forks source link

Title search button missing #30

Closed TomW1605 closed 3 years ago

TomW1605 commented 3 years ago

Description

The json ajax change removed the title search button

2021-03-09 07 49 29 the dvd is actualy Apolo 13 but the search button is missing so i cant fix it.

i think there are some other things missing but i cant remember what they are.

1337-server commented 3 years ago

Great catch!

I have added back the missing buttons and missing information

TomW1605 commented 3 years ago

great i will test it when i get home from work

TomW1605 commented 3 years ago

i would also recomend swaping back to text for the status instead of icons or add an icon key. relying on tool tips is a bit anoying on desktop but very painful on a mobile device

TomW1605 commented 3 years ago

now i am getting a java script error:

index.html:320 Uncaught TypeError: Cannot read property 'RIPMETHOD' of undefined
    at addJobItem (index.html:320)
    at Object.<anonymous> (index.html:356)
    at Function.each (jquery-3.5.1.min.js:2)
    at Object.success (index.html:355)
    at c (jquery-3.5.1.min.js:2)
    at Object.fireWith [as resolveWith] (jquery-3.5.1.min.js:2)
    at l (jquery-3.5.1.min.js:2)
    at XMLHttpRequest.<anonymous> (jquery-3.5.1.min.js:2)
addJobItem @ index.html:320
(anonymous) @ index.html:356
each @ jquery-3.5.1.min.js:2
success @ index.html:355
c @ jquery-3.5.1.min.js:2
fireWith @ jquery-3.5.1.min.js:2
l @ jquery-3.5.1.min.js:2
(anonymous) @ jquery-3.5.1.min.js:2
load (async)
send @ jquery-3.5.1.min.js:2
ajax @ jquery-3.5.1.min.js:2
refreshJobs @ index.html:347
(anonymous) @ index.html:371
1337-server commented 3 years ago

Can you take a look at your json?mode=joblist page and see if each job has a config key set

TomW1605 commented 3 years ago

no

{
    "mode": "joblist",
    "results": {
        "0": {
            "arm_version": "2.5.0_dev",
            "crc_id": "13f0884508085c7b",
            "devpath": "/dev/sr0",
            "disctype": "dvd",
            "ejected": "False",
            "errors": "None",
            "eta": "00h16m17s",
            "hasnicetitle": "True",
            "imdb_id": "tt0454435",
            "imdb_id_auto": "None",
            "imdb_id_manual": "None",
            "job_id": "124",
            "job_length": "None",
            "label": "D091_AFRICANQUEEN",
            "logfile": "D091_AFRICANQUEEN.log",
            "mountpoint": "/mnt/dev/sr0",
            "no_of_titles": "14",
            "pid": "79905",
            "pid_hash": "2207746297383672243",
            "poster_url": "https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg",
            "poster_url_auto": "https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg",
            "poster_url_manual": "None",
            "progress": "1.70",
            "progress_round": 1,
            "stage": "1 of 1",
            "start_time": "2021-03-10 07:33:32.392276",
            "status": "transcoding",
            "stop_time": "None",
            "title": "D",
            "title_auto": "D",
            "title_manual": "None",
            "updated": "False",
            "video_type": "movie",
            "video_type_auto": "movie",
            "video_type_manual": "None",
            "year": "2005",
            "year_auto": "2005",
            "year_manual": "None"
        }
    },
    "success": true
}
1337-server commented 3 years ago

Are there any logged errors in your webui log ?

Not sure why it's not pushing out the config.

TomW1605 commented 3 years ago

here is the python log

192.168.3.1 - - [10/Mar/2021 16:53:55] "GET /json?mode=joblist HTTP/1.0" 200 -
[2021-03-10 16:54:09,045] DEBUG in routes: joblist
[2021-03-10 16:54:09,051] DEBUG in utils: b'[10-03-2021 16:54:04] INFO ARM: main.main Waiting 60 seconds for manual override.\n'
[2021-03-10 16:54:09,051] DEBUG in utils: job obj= {'logfile': 'D091_AFRICANQUEEN_161536643784.log', 'imdb_id_auto': 'None', 'year': '2005', 'disctype': 'dvd', 'start_time': '2021-03-10 16:53:57.887718', 'imdb_id_manual': 'None', 'year_auto': '2005', 'label': 'D091_AFRICANQUEEN', 'stop_time': 'None', 'poster_url': 'https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg', 'year_manual': 'None', 'ejected': 'False', 'errors': 'None', 'job_id': '125', 'job_length': 'None', 'poster_url_auto': 'https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg', 'video_type': 'movie', 'updated': 'False', 'status': 'waiting', 'poster_url_manual': 'None', 'video_type_auto': 'movie', 'pid': '82022', 'no_of_titles': 'None', 'devpath': '/dev/sr0', 'arm_version': '2.5.0_dev', 'video_type_manual': 'None', 'pid_hash': '1278483654627681415', 'title': 'D', 'mountpoint': '/mnt/dev/sr0', 'crc_id': '13f0884508085c7b', 'imdb_id': 'tt0454435', 'title_auto': 'D', 'hasnicetitle': 'True', 'title_manual': 'None'}
[2021-03-10 16:54:09,052] DEBUG in utils: job obj.items= dict_items([('logfile', 'D091_AFRICANQUEEN_161536643784.log'), ('imdb_id_auto', 'None'), ('year', '2005'), ('disctype', 'dvd'), ('start_time', '2021-03-10 16:53:57.887718'), ('imdb_id_manual', 'None'), ('year_auto', '2005'), ('label', 'D091_AFRICANQUEEN'), ('stop_time', 'None'), ('poster_url', 'https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg'), ('year_manual', 'None'), ('ejected', 'False'), ('errors', 'None'), ('job_id', '125'), ('job_length', 'None'), ('poster_url_auto', 'https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg'), ('video_type', 'movie'), ('updated', 'False'), ('status', 'waiting'), ('poster_url_manual', 'None'), ('video_type_auto', 'movie'), ('pid', '82022'), ('no_of_titles', 'None'), ('devpath', '/dev/sr0'), ('arm_version', '2.5.0_dev'), ('video_type_manual', 'None'), ('pid_hash', '1278483654627681415'), ('title', 'D'), ('mountpoint', '/mnt/dev/sr0'), ('crc_id', '13f0884508085c7b'), ('imdb_id', 'tt0454435'), ('title_auto', 'D'), ('hasnicetitle', 'True'), ('title_manual', 'None')])
[2021-03-10 16:54:09,052] DEBUG in utils: Stuff = {0: {'logfile': 'D091_AFRICANQUEEN_161536643784.log', 'imdb_id_auto': 'None', 'year': '2005', 'disctype': 'dvd', 'start_time': '2021-03-10 16:53:57.887718', 'imdb_id_manual': 'None', 'year_auto': '2005', 'label': 'D091_AFRICANQUEEN', 'stop_time': 'None', 'poster_url': 'https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg', 'year_manual': 'None', 'ejected': 'False', 'errors': 'None', 'job_id': '125', 'job_length': 'None', 'poster_url_auto': 'https://m.media-amazon.com/images/M/MV5BOGY5ZmM0MmMtZmEzOS00YjA0LTk5OGYtNjYwYTdlMjFkMGY2XkEyXkFqcGdeQXVyODE5NzE3OTE@._V1_SX300.jpg', 'video_type': 'movie', 'updated': 'False', 'status': 'waiting', 'poster_url_manual': 'None', 'video_type_auto': 'movie', 'pid': '82022', 'no_of_titles': 'None', 'devpath': '/dev/sr0', 'arm_version': '2.5.0_dev', 'video_type_manual': 'None', 'pid_hash': '1278483654627681415', 'title': 'D', 'mountpoint': '/mnt/dev/sr0', 'crc_id': '13f0884508085c7b', 'imdb_id': 'tt0454435', 'title_auto': 'D', 'hasnicetitle': 'True', 'title_manual': 'None'}}
[2021-03-10 16:54:09,052] DEBUG in utils: jobs  - we have jobs
192.168.3.1 - - [10/Mar/2021 16:54:09] "GET /json?mode=joblist HTTP/1.0" 200 -
TomW1605 commented 3 years ago

nvm i think something went wrong when i uploaded the update to my server. the index was updated but not the routes.py. it is working now

TomW1605 commented 3 years ago

actually now it is missing the abandon and delete buttons. 2021-03-10 17 05 45

also the poster visubley refreshes every time it updates. might be worth having it compare the old url to the new one before changing it so the browser does not reload it.

1337-server commented 3 years ago

Can you check your index.html and make sure it matches with the latest commit ?

or verify that <button type="button" class="btn btn-primary" data-toggle="modal" data-target="#exampleModal" data-type="abandon" data-jobid="' + job["job_id"] + '" data-href="json?job=' + job["job_id"] + '&mode=abandon">Abandon Job</button>\ Exists in index.html

EDIT:

also the poster visubley refreshes every time it updates. might be worth having it compare the old url to the new one before changing it so the browser does not reload it.

I had thought about saving the remote image to the local movie folder and having ARM serve the local image instead of remote, but I'm not sure of the best way to achieve this yet.

TomW1605 commented 3 years ago

ok you were right. the local version matched the last commit but the remote one did not.

as for the icons i will make a new issue for that