search

13rac1 / block-fixup-merge-action

Github Action to block merge of Pull Requests containing fixup! or squash! commits
MIT License
46 stars 14 forks source link

fix: cover Git 2.32.0, check for `amend!` commits #26

Open ErichDonGubler opened 2 years ago

ErichDonGubler commented 2 years ago

This adds coverage for the new amend! commit prefixes added with the --fixup={reword,amend}... variants.

I'm unclear on whether or not this would be considered a breaking change?

Closes #25.

MartinDelille commented 2 years ago

A nicer solution would be to make configurable the list of forbidden string in the git history (I would personnaly enjoy to add "wip!" for example)

ErichDonGubler commented 2 years ago

A nicer solution would be to make configurable the list of forbidden string in the git history (I would personnaly enjoy to add "wip!" for example)

AFAIK these aren't part of the normal autosquash flow in Git, which is what this PR was motivated by. Not saying whether or not your suggestion should be implemented, just noting the context here.

As for your request, I suspect another issue would be the most effective way to drive discussion.