search

13xforever / ps3-disc-dumper

A handy utility to make decrypted PS3 disc dumps
MIT License
434 stars 29 forks source link

Invalid Characters in game name causes "Invalid argument" System.IO.IOException error #20

Closed alexmmych closed 2 years ago

alexmmych commented 2 years ago

System: Manjaro Linux App Version: v.3.2.1

Steps to reproduce:

  1. Put in a disc of a game which contains a "™" character and mount it.
  2. Use the PS3 disc dumper app.
  3. Wait for the disc to be first read
  4. See "Invalid argument" error

This error seems to be caused by the System.IO.Directory.CreateDirectory(String path) function and the System.IO.FileSystem.CreateDirectory(String fullPath) as described in the log output at the end of the file. This error occured when I tried to dump "[BCES01175] Uncharted 3: Drake's Deception™"

2022-02-17.log

This error can be circumvented by automatically removing the characters which are causing problem and or allowing the user to rename the output path of the file with a --rename variable, the ladder being more versatile since invalid characters can depend from system to system.

Thank you for the trouble and thank you so much for making such an incredible tool! :+1:

13xforever commented 2 years ago

Trademark is not an issue, unless you have weird codepage configured for your filesystem, and I already strip it among other stuff, just for more readable titles. I'll look at the log on weekend.

alexmmych commented 2 years ago

Figured it out. On Manjaro Linux ":" is an illegal character. Either way there should be an option to rename the output name of the folder for these cases.

13xforever commented 2 years ago

again, it depends on the filesystem and I already filter out characters that are not valid according to the runtime/system

alexmmych commented 2 years ago

again, it depends on the filesystem and I already filter out characters that are not valid according to the runtime/system

13xforever commented 2 years ago

Please don't close the issue when I haven't even had a chance to dig out the root cause

13xforever commented 2 years ago

Please try the new build 3.2.2, it should work

alexmmych commented 2 years ago

The same issue still occurs. The output name still contains ":" and thus it can't create a folder with that name.

2022-02-20.log

13xforever commented 2 years ago

Are you dumping to an NTFS mount? Because Linux native filesystems can use : just fine

alexmmych commented 2 years ago

Are you dumping to an NTFS mount? Because Linux native filesystems can use : just fine

Omg you are right! I can dump perfectly on an ext4 drive. Thanks for guiding me!

13xforever commented 2 years ago

I've updated the linux build of 3.2.2 to explicitly remove most common windows-specific characters