search

13xforever / x86-assembly-textmate-bundle

A bundle for TextMate/Sublime Text providing syntax highlighting for x86 assembly code.
MIT License
82 stars 24 forks source link

fixed comments starting with '#' #4

Closed acidghost closed 8 years ago

acidghost commented 8 years ago

This PR enables syntax highlighting for comment lines starting with '#' (without breaking preprocessor commands highlighting).

13xforever commented 8 years ago

So, I looked into it, and here's the problem I have with this:

label# mov ax, bx

This is a valid nasm syntax that will be marked as label + comment. Considering that # is used mainly for GAS comments, I have some doubts about merging this into this highlighter which is targeting NASM syntax primarily.

On the other hand, I do not highlight labels without explicit : at the end and this change won't break this.

13xforever commented 8 years ago

I did slightly modified version in 2.2.4 which should be out now.

acidghost commented 8 years ago

Updated, works great, thanks!