search

152334H / tortoise-tts-fast

Fast TorToiSe inference (5x or your money back!)
GNU Affero General Public License v3.0
771 stars 179 forks source link

A better way to deal with package management? #23

Closed Ryu1845 closed 1 year ago

Ryu1845 commented 1 year ago

Currently, it looks like the chosen mechanism is to lock the version to a requirements-version.txt file. I think adding support for a proper dependency management tool like poetry or pyflow could be nice. Or maybe at least use something like https://github.com/jazzband/pip-tools/ to correctly lock them using hashes. P.S. I'd be happy to add one myself :smile:

152334H commented 1 year ago

I will probably not use the new dependency management system, if it is added. I have not used any of the mentioned tooling before and will not be capable of maintaining it.

I do not see any inherent problems with adding it, though, since I doubt it would break anything

Ryu1845 commented 1 year ago

Alright, I'll make a PR for it. I think that would be a useful tool to make publishing the project on PyPI eventually too.

152334H commented 1 year ago

since I doubt it would break anything

This was incredibly wrong

Making a new env now for this project specifically :)

Ryu1845 commented 1 year ago

What went wrong?

152334H commented 1 year ago

I was sharing the env with other projects, which was a huge problem for creating a good requirements.txt file

Also, streamlit/voicefixer was missing from pyproject.toml, and the former needed a change to the python version

But I made a new venv so it should be fine now

Ryu1845 commented 1 year ago

Ok nice. I guess I can close this issue now?

Ryu1845 commented 1 year ago

Implemented in #25 for future reference