Closed Ryu1845 closed 1 year ago
I will probably not use the new dependency management system, if it is added. I have not used any of the mentioned tooling before and will not be capable of maintaining it.
I do not see any inherent problems with adding it, though, since I doubt it would break anything
Alright, I'll make a PR for it. I think that would be a useful tool to make publishing the project on PyPI eventually too.
since I doubt it would break anything
This was incredibly wrong
Making a new env now for this project specifically :)
What went wrong?
I was sharing the env with other projects, which was a huge problem for creating a good requirements.txt file
Also, streamlit/voicefixer was missing from pyproject.toml, and the former needed a change to the python version
But I made a new venv so it should be fine now
Ok nice. I guess I can close this issue now?
Implemented in #25 for future reference
Currently, it looks like the chosen mechanism is to lock the version to a
requirements-version.txt
file. I think adding support for a proper dependency management tool like poetry or pyflow could be nice. Or maybe at least use something like https://github.com/jazzband/pip-tools/ to correctly lock them using hashes. P.S. I'd be happy to add one myself :smile: