search

1602 / compound

MVC framework. Built on Node.JS. Works on server and browser.
http://compoundjs.com
1.6k stars 183 forks source link

renderSection + relevant tests #606

Closed hankeypancake closed 10 years ago

hankeypancake commented 10 years ago

Added the feature. Tests are passing, but should be reviewed anyway

1602 commented 10 years ago
  1. copy&paste detected :)
  2. could you please point me where I can find discussion about this feature to get high-level idea behind this
hankeypancake commented 10 years ago
  1. Yes, but it's not a crime.. as long as it does not breaking anything? (:
  2. this issue: https://github.com/1602/compound/issues/603
randunel commented 10 years ago

I think the existing .render function could be adapted for this functionality, eliminating the duplicate code, but then the code would look extremely ugly if backward compatibility were to be maintained :/

anatoliychakkaev commented 10 years ago
  1. it's a crime.

On Thu, Jan 23, 2014 at 2:31 PM, Henrik Myntti notifications@github.comwrote:

  1. Yes, but it's not a crime.. as long as it does not breaking anything? (:

  2. 603 https://github.com/1602/compound/issues/603

— Reply to this email directly or view it on GitHubhttps://github.com/1602/compound/pull/606#issuecomment-33128058 .

hankeypancake commented 10 years ago

yup. I think it should be separate functions, but implemented better. I'll look at it again, because right now it's actually quite ugly