search

1602 / jugglingdb

Multi-database ORM for nodejs: redis, mongodb, mysql, sqlite3, postgresql, arango, in-memory...
http://1602.github.io/jugglingdb/
2.04k stars 241 forks source link

Fixed a scope issue with the toObject method when printing all enumerable properties #321

Closed making3 closed 10 years ago

making3 commented 11 years ago

Replaces this[attr] with self[attr] in toObject for enumerable properties inside of the model.js library.

absynce commented 10 years ago

@1602, is there an issue with this to prevent it from being merged?

1602 commented 10 years ago

@absynce thanks for pointing it out. merged.

1602 commented 10 years ago

Actually it was already implemented by another commit with correct version update. BTW, pull request should not update version.

making3 commented 10 years ago

@1602, I understand, I don't plan on updating the version with the pull request (if I make another request, I'll try to exclude it, or make a separate branch that has the version updated). It's typically updated on our end so we can use a temporary version of the package with npm in our project.