search

1602 / jugglingdb

Multi-database ORM for nodejs: redis, mongodb, mysql, sqlite3, postgresql, arango, in-memory...
http://1602.github.io/jugglingdb/
2.04k stars 241 forks source link

Added date tests to basic-querying to ensure client encoding is applied ... #328

Open wwoods opened 11 years ago

wwoods commented 11 years ago

...to queries as well as data. At least the client driver for rethinkdb was exhibiting broken behavior when dates were queried, even though all tests were passing previously.

1602 commented 11 years ago

This test cases specific to sql (and other adapter supporting 'lt' operator) right? Would be great to test it separately and not in basic querying section.

wwoods commented 11 years ago

Ah, didn't think about some adapters not supporting lt. Where would you recommend it be set up..? I'm not too familiar with the jugglingdb code, if you point me in the right direction I'd be happy to fix up this request to be friendly to drivers without lt support.

anatoliychakkaev commented 11 years ago

Redis adapter doesn't support that feature. Just use separate file named something.test.js with your test case, please make sure memory adapter pass this test. Next step will be: include this test in all adapters that support that feature (lt).

On Fri, Sep 27, 2013 at 5:17 PM, Walt Woods notifications@github.comwrote:

Ah, didn't think about some adapters not supporting lt. Where would you recommend it be set up..? I'm not too familiar with the jugglingdb code, if you point me in the right direction I'd be happy to fix up this request to be friendly to drivers without lt support.

— Reply to this email directly or view it on GitHubhttps://github.com/1602/jugglingdb/pull/328#issuecomment-25257406 .