search

1602 / jugglingdb

Multi-database ORM for nodejs: redis, mongodb, mysql, sqlite3, postgresql, arango, in-memory...
http://1602.github.io/jugglingdb/
2.05k stars 241 forks source link

Select Specific Columns(mysql-adapter) #381

Closed jvskelton closed 10 years ago

jvskelton commented 10 years ago

-Added AbstractClass.select to facilitate specific column select statements in mysql adapter. -Currently only supported in jvskelton/jugglingdb-mysql -A pull request will be created for jvskelton/jugglingdb-mysql(forked from jugglingdb/mysql-adapter) when changes have been accepted.

1602 commented 10 years ago

This pr was closed because it contains full copy of jugglingdb inside jugglingdb repository. I would recommend you to make your fixes directly on codebase and not on its copy, which is a proper way to work with git. Branching model in git slightly differs with svn.

jvskelton commented 10 years ago

I apologize for that, when i made the pull request I did not realize it included the entire copy and not just my changes.

anatoliychakkaev commented 10 years ago

No probs. Shit happens :) You can just fork it again and copy your code over existing codebase, check git diff then - it should show only necessary changes. Good luck!

On 28 February 2014 14:37, jvskelton notifications@github.com wrote:

I apologize for that, when i made the pull request I did not realize it included the entire copy and not just my changes.

Reply to this email directly or view it on GitHubhttps://github.com/1602/jugglingdb/pull/381#issuecomment-36355896 .