search

16colo-rs / 16c

16colo.rs ANSI/ASCII Archive
5 stars 1 forks source link

in-pack Ajax search does not work on mobile #3

Closed bart-d closed 4 years ago

lordscarlet commented 4 years ago

What aspect of this doesn't work? If I use the Chrome Dev Tools emulator, and I remove the class that hides the search on mobile, the functionality works. Is this an instance where the emulator doesn't show a true picture, or am I missing something? (clearly it needs some slightly different styles on mobile)

image

bart-d commented 4 years ago

i noticed this myself on Android (Chrome and FF). i think it's related to the search being triggered on keyup, maybe those events don't exist or behave differently on mobile.

bart-d commented 4 years ago

i tried this again, on a mobile device and it works. but the searchbox takes up so much space, i'm considering to leave it hidden on mobile.

lordscarlet commented 4 years ago

Yeah, its a bit of a ui problem as far as that goes. You could probably position or size it a little better, but its always going to be fairly large. You could perhaps cause it to open a modal on mobile? Not sure the right answer. Someone can also use the mobile browser Find in page functionality.

bart-d commented 4 years ago

indeed, i'm going to put it to rest for now :)