search

16n-faderbank / 16n

Sixteen faders, a Teensy, MIDI over USB and jack, CV out, and I2C out. Phew.
Other
337 stars 58 forks source link

Hack/fix of the Fader read issue #60

Open AtoVproject opened 3 years ago

infovore commented 3 years ago

Oops, sorry, only just seen this - yes, I should get this out and do a 2.1.1 release off the back of it asap. Thanks for the PR, it's appreciated.

AtoVproject commented 3 years ago

Hi Tom,

No worries. I don't really understand what is causing the issue. I think that having the 16n as i2c master might have something to do with it. The microdelay seem to be fixing the issue. It's a bit hacky thought... Let me if you find a better solution.

Cheers

On Tue, 28 Sep 2021, 19:40 Tom Armitage, @.***> wrote:

Oops, sorry, only just seen this - yes, I should get this out and do a 2.1.1 release off the back of it asap. Thanks for the PR, it's appreciated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/16n-faderbank/16n/pull/60#issuecomment-929481283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWC6CIT6MBDBIKQ2B63MM3UEH42JANCNFSM5CVGLQGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

infovore commented 3 years ago

I genuinely think it's analog in nature, to do with switching mux channel but not giving it time to change. I don't know. For the sake of a microsecond lockup, I'm fine with this - it's what we had before - and in general, whenever I'm switching a mux, I always wait a little - most MCUs are just faster than those old CMOS parts, I believe...

AtoVproject commented 3 years ago

Good to know.

That's what i suspected as well as it's never the same fader that has issues. I think that manufacturing tolerances the mux might be also playing a role.

Anyways, if you are fine with it I'm fine with that.

On Wed, 29 Sep 2021, 19:52 Tom Armitage, @.***> wrote:

I genuinely think it's analog in nature, to do with switching mux channel but not giving it time to change. I don't know. For the sake of a microsecond lockup, I'm fine with this - it's what we had before - and in general, whenever I'm switching a mux, I always wait a little - most MCUs are just faster than those old CMOS parts, I believe...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/16n-faderbank/16n/pull/60#issuecomment-930408805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWC6CJAKB7BCJ266AA3WL3UENG7JANCNFSM5CVGLQGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.