search

1701-jan09-java / interview-evaluations

Interview Evaluations Microservice
MIT License
1 stars 9 forks source link

Feat/all members for branch #20

Closed sharangw closed 7 years ago

sharangw commented 7 years ago

Adding all the things

octocat-jedi commented 7 years ago

SonarQube analysis reported 19 issues

Watch the comments in this conversation to review them.

5 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR PersonController.java#L19: Remove this unused import 'com.revature.domain.PersonRole'. rule
  2. MINOR PersonController.java#L20: Remove this unused import 'com.revature.services.BatchLogic'. rule
  3. MINOR BatchLogicImpl.java#L26: Immediately return this expression instead of assigning it to the temporary variable "batch". rule
  4. MINOR BatchLogicImpl.java#L32: Immediately return this expression instead of assigning it to the temporary variable "batch". rule
  5. MINOR PersonLogicImpl.java#L3: Remove this unused import 'java.util.List'. rule