search

1701-jan09-java / interview-evaluations

Interview Evaluations Microservice
MIT License
1 stars 9 forks source link

Temp efren patch create person #23

Closed eeolivas closed 7 years ago

eeolivas commented 7 years ago

forces complete and valid fields for createPerson method

octocat-jedi commented 7 years ago

SonarQube analysis reported 34 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR PersonController.java#L44: Replace this usage of System.out or System.err by a logger. rule
  2. MAJOR QuestionComment.java#L26: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  3. MAJOR QuestionComment.java#L64: This block of commented-out lines of code should be removed. rule
  4. MAJOR QuestionEval.java#L36: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  5. MAJOR QuestionPool.java#L37: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  6. MAJOR EvalLogicImpl.java#L89: Replace this usage of System.out or System.err by a logger. rule
  7. MAJOR PersonLogicImpl.java#L69: Either log or rethrow this exception. rule
  8. MINOR PersonController.java#L15: Remove this unused import 'org.springframework.web.servlet.mvc.method.annotation.ResponseBodyEmitterReturnValueHandler'. rule
  9. MINOR PersonController.java#L17: Remove this unused import 'com.revature.domain.Batch'. rule
  10. MINOR PersonController.java#L19: Remove this unused import 'com.revature.domain.PersonRole'. rule