search

1701-jan09-java / interview-evaluations

Interview Evaluations Microservice
MIT License
1 stars 9 forks source link

can no longer overwrite by creating person with same id #24

Closed eeolivas closed 7 years ago

octocat-jedi commented 7 years ago

SonarQube analysis reported 10 issues

Watch the comments in this conversation to review them.

9 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR PersonController.java#L44: Replace this usage of System.out or System.err by a logger. rule
  2. MAJOR PersonLogicImpl.java#L69: Either log or rethrow this exception. rule
  3. MAJOR PersonLogicImpl.java#L105: Replace this usage of System.out or System.err by a logger. rule
  4. MAJOR PersonLogicImpl.java#L114: Replace this usage of System.out or System.err by a logger. rule
  5. MINOR PersonController.java#L15: Remove this unused import 'org.springframework.web.servlet.mvc.method.annotation.ResponseBodyEmitterReturnValueHandler'. rule
  6. MINOR PersonController.java#L17: Remove this unused import 'com.revature.domain.Batch'. rule
  7. MINOR PersonController.java#L19: Remove this unused import 'com.revature.domain.PersonRole'. rule
  8. MINOR PersonController.java#L20: Remove this unused import 'com.revature.services.BatchLogic'. rule
  9. MINOR PersonController.java#L22: Remove this unused import 'com.revature.services.PersonRoleLogic'. rule