search

1701-jan09-java / interview-evaluations

Interview Evaluations Microservice
MIT License
1 stars 9 forks source link

Feat/all members for branch #29

Closed cmatheny closed 7 years ago

cmatheny commented 7 years ago

I finished yannick's branch for him

octocat-jedi commented 7 years ago

SonarQube analysis reported 8 issues

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR JsonValidation.java#L54: Define a constant instead of duplicating this literal "Missing required field " 15 times. rule
  2. MINOR JsonValidation.java#L74: Define a constant instead of duplicating this literal " does not exist" 9 times. rule