search

1701-jan09-java / interview-evaluations

Interview Evaluations Microservice
MIT License
1 stars 9 forks source link

fix loophole for creating person with empty string values #30

Closed eeolivas closed 7 years ago

octocat-jedi commented 7 years ago

SonarQube analysis reported 7 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR JsonValidation.java#L297: Replace this usage of System.out or System.err by a logger. rule
  2. MAJOR JsonValidation.java#L346: Either log or rethrow this exception. rule
  3. MINOR JsonValidation.java#L19: Remove this duplicated import. rule
  4. MINOR JsonValidation.java#L20: Remove this duplicated import. rule
  5. MINOR JsonValidation.java#L21: Remove this duplicated import. rule
  6. MINOR JsonValidation.java#L73: Define a constant instead of duplicating this literal "Missing required field " 15 times. rule
  7. MINOR JsonValidation.java#L93: Define a constant instead of duplicating this literal " does not exist" 9 times. rule