search

1701-jan09-java / interview-evaluations

Interview Evaluations Microservice
MIT License
1 stars 9 forks source link

change deletes to return json in batch and eval logic #35

Closed sharangw closed 7 years ago

octocat-jedi commented 7 years ago

SonarQube analysis reported 13 issues

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR BatchLogicImpl.java#L125: Move the "" string literal on the left side of this string comparison. rule
  2. MAJOR BatchLogicImpl.java#L145: Remove those useless parentheses. rule
  3. MAJOR BatchLogicImpl.java#L145: Replace the type specification in this constructor call with the diamond operator ("<>"). rule
  4. MAJOR EvalLogicImpl.java#L44: Replace this usage of System.out or System.err by a logger. rule
  5. MAJOR EvalLogicImpl.java#L60: Remove useless curly braces around statement rule
  6. MAJOR EvalLogicImpl.java#L72: Remove useless curly braces around statement rule
  7. MAJOR EvalLogicImpl.java#L278: Remove useless curly braces around statement rule
  8. MINOR BatchLogicImpl.java#L145: Immediately return this expression instead of assigning it to the temporary variable "personPage". rule
  9. MINOR EvalLogicImpl.java#L54: Remove the parentheses around the "question" parameter rule
  10. MINOR EvalLogicImpl.java#L60: Remove the parentheses around the "comment" parameter rule