Polygons should only close when completed - Githubissues

1715labs / 1715labs-pfe

Modified version of PFE for use with paid crowds

1715labs-pfe.vercel.app

Apache License 2.0

0 stars 0 forks source link

Polygons should only close when completed #19

Closed tingard closed 3 years ago

tingard commented 3 years ago

Expected behaviour

The polygon tool should only close when the worker clicks on the initial marking, completing the loop.

Current behaviour

Closing a polygon can be done by clicking on the starting point or the most recent marking, leading to accidental polygon closure for high-resolution polygons.

rogerhutchings commented 3 years ago

Side effects:

This will affect behaviour for all projects using this polygon tool - we'll have to revert this change if we want things to go back
It'll be possible to submit unclosed polygons

tingard commented 3 years ago

Is it not already possible to submit unclosed polygons?

rogerhutchings commented 3 years ago

I can't remember if it closes them automagically. Probably not, come to think of it

rogerhutchings commented 3 years ago

IT TOTALLY DOES

tingard commented 3 years ago

Is that desired behaviour? Should we allow the submission of unclosed polygons?

rogerhutchings commented 3 years ago

If you have an open polygon and click "Done", it gets closed

(thank whoever wrote it for that one)

rogerhutchings commented 3 years ago

On reflection, changing this wouldn't have affected that either way, derp