1715labs / 1715labs-pfe

Modified version of PFE for use with paid crowds
1715labs-pfe.vercel.app
Apache License 2.0
0 stars 0 forks source link

Allow workflow url parameter on inactive workflows #27

Open tingard opened 3 years ago

tingard commented 3 years ago

Expected behavior

Specifying a workflow in the URL should always load that workflow, regardless of whether the workflow is active

Current behavior

If the workflow is inactive, a random alternate active workflow is selected, and query parameters are discarded.

tingard commented 3 years ago

I've been thinking about this, and I think the best thing to do is simply remove most of the "if this then that" from https://github.com/zooniverse/Panoptes-Front-End/blob/45399f3267f45fa1d67d5bcd162b4050ed11e5ac/app/pages/project/workflow-selection.jsx#L50, such that we

That way, we can have a constant project url of /projects/1715labs/crowd-facing/classify?workflow=...., which simplifies a lot of the AAAPI redirecting (don't need a project slug or anything, just ID of workflow + subject(s).

@rogerhutchings thoughts?

tingard commented 3 years ago

Related to #33 - better to error out if the workflow is not active, though I still think allowing a workflow to come from any project makes sense from a config perspective, as the concept of projects doesn't need to exist in our classifier UI