Strip back workflow selection logic WIP

1715labs / 1715labs-pfe

Modified version of PFE for use with paid crowds

1715labs-pfe.vercel.app

Apache License 2.0

0 stars 0 forks source link

Strip back workflow selection logic WIP #37

Open rogerhutchings opened 3 years ago

rogerhutchings commented 3 years ago

This strips out a lot of unused code for workflow selection that we don't use. Now:

Workflows must now always be specified via a query parameter
Query parameter workflow selection is always active
There are no checks for whether a workflow is active or not
There are no fallback checks for workflows; failure will produce an error

Close #13 Close #18 Close #27 Close #33

Supersedes #32

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1715labs/1715labs-pfe/3NGv87xrJ2B5YhsHeMiQiU4g9XNW
✅ Preview: https://1715labs-pfe-git-workflow-selection-1715labs.vercel.app

rogerhutchings commented 3 years ago

ARG IT BREAK

specifically it appears that there is some code that expects the selected workflow to belong to the correct project. there isn't an error being thrown though

tingard commented 2 years ago

@rogerhutchings try changing this line to always be true

https://github.com/1715labs/1715labs-pfe/blob/master/app/pages/project/workflow-selection.jsx#L159