Closed rogerhutchings closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/1715labs/1715labs-pfe/Bk8yANQVigLnGxKxUxzBzjvY5psh
✅ Preview: https://1715labs-pfe-git-maker-checker-1715labs.vercel.app
First thoughts:
Cannot read property 'annotations' of undefined
)I've also noticed that "persist annotations" is now ignored? i.e. I would imagine that with "persist annotations" enabled then going back to a previous task then forwards again would preserve the changes I've made to the default classification, whereas going backwards + forwards without "persist annotations" would reset the values back to the default for that task?
Edit: Also - I've checked and persist annotations ignores any changes to the value of a single-choice question, which is counter-intuitive (I'd have imagined that it would persist the choice made, rather than revert to the default)
The only breaking issue I've spotted is that we need to handle the case where "classification" is not present in the subject metadata, and so no default should be specified".
It also doesn't yet support "allow multiple" in categorisation tasks, which we do sometimes use
I haven't tested this scenario, but I've intentionally kept the code dumb, so I suspect it would try and render a mark with the wrong tool and fall over. To be honest, I think it should error out to prevent wasted work
classification
propertyThis is a bug, I'll put a fix in. Thanks for spotting it!
That shouldn't be too hard to add; if I had to guess, value
for this task changes type (quiet facepalm) to array, so we just need to handle that.
That shouldn't be too hard to add; if I had to guess, value for this task changes type (quiet facepalm) to array, so we just need to handle that.
That's exactly it - you get an array of selected answer indices
Adds in a maker-checker feature to PFE.
How it works
Annotations should be added to a subject's metadata - if present, they'll be rendered as the worker moves between tasks.
Example subject (note the
metadata.classification
property)If a subject contains existing annotations for a task on a workflow, they'll be added to the annotations state.
Currently works for
Other tool types may require adding additional code, since we're trying to mimic the output from the actual drawing task in order to make this work.
To do