search

1719pankaj / Dank-Memes-2

7 stars 5 forks source link

ViewPager-2 implementation #3

Open 1719pankaj opened 3 years ago

1719pankaj commented 3 years ago

The project currently uses Shared intents and Views for onboarding. ViewPager2 needs to replace it all.

krishnachaitanya0107 commented 3 years ago

Hey , I am interested in working on this issue . If the issue is still open , Can you please assign it to me .

Also , I have a few doubts about this issue . Please help me out by answering the following questions -

  1. Should I convert the signup and login activities ( both phone and Mail auth) into fragments to use in the viewpager and then use the viewpager in a new activity ?

  2. I couldn't understand the ' replace shared intents with viewpager ' part , could you please give me some more clarity on this ?

1719pankaj commented 3 years ago

There's been some recent contribution and this issue become a bit more complex And a few things need to be done.

First of all strip out firebase from the project,

There's new login activities and they all need to be converted to fragments and their navigation tied to jetpack navigation

And then finally everything between splash and mainfragment screen need to be put into viewpager2

One time onboarding process should run or not is dictated by a shared Boolean value And that can be ignored for now. It needs more work I'll create a seperate once I get some time off.

1719pankaj commented 3 years ago

I'd be more than happy to assign it to you Just let me know.

krishnachaitanya0107 commented 3 years ago

Thank you for such a quick response , So removing firebase from the project would mean that the auth part would need to be completely reworked and also i have never worked with jetpack compose yet , so i might not be able to implement that part . I will let you know if i can help you out with any of the other issues . Thank You

1719pankaj commented 3 years ago

Oookie cool

1719pankaj commented 3 years ago

Oh and By stip out I menat just deleting the firebase json file, it's currently logged. Into a contributor's firebase account. No need to rework the auth, it's perfect.

And we are not using jetpack compose for anything We are using only jetpack navigation RN.

Ps. I had to write this in case someone else is looking at the thread.