search

17cupsofcoffee / tetra

🎮 A simple 2D game framework written in Rust
MIT License
909 stars 63 forks source link

Updated vek dependency #254

Closed VictorKoenders closed 3 years ago

VictorKoenders commented 3 years ago

Updated vek dependency from 1.13.1 to 0.15.0

Vek's diff: https://github.com/yoanlcq/vek/compare/7a3bca71a05d7c54ef98dc2d67270f04fb2719ec..837cd9bd08f3927dfdbbb8e2223496e77e6533ef

17cupsofcoffee commented 3 years ago

Hm, I was holding off on doing this because any breaking changes to vek are technically also breaking changes to tetra (due to the re-export). But looking at the diff, the changes seem very minor - the only potential breaking change is MulAdd being replaced with the version from num-traits, but I think in practice that's very unlikely to cause breakage, so it's prooooobably okay?

VictorKoenders commented 3 years ago

Dependency updates are a tricky thing. Some people think it's a breaking change and would do a most significant version update, others think it's fine as long as the API doesn't break.

For my projects it wouldn't be a breaking change if tetra 0.6.4 would have updated vek to 0.15, but I'm not fussed if you wait with this until tetra 0.7.0

VictorKoenders commented 3 years ago

Going to close this in favor of #259