Tairesh
commented
2 years ago Added binding for SDL_OpenURL
Wow, this can be useful
Closed dependabot[bot] closed 2 years ago
Tairesh
commented
2 years ago Added binding for SDL_OpenURL
Wow, this can be useful
17cupsofcoffee
commented
2 years ago @Tairesh That does seem handy 😄 Though I need to be kinda careful about using functionality that's relatively new in SDL2, I've had issues before where old versions would fail to link properly to the sdl2 crate. Might have just been me doing something wrong though, I'll have to experiement some more.
dependabot[bot]
commented
2 years ago Looks like sdl2 is up-to-date now, so this is no longer needed.
17cupsofcoffee
commented
2 years ago I ran into the linking issue I mentioned after updating the dependency - even though I don't use SDL_OpenURL anywhere in my code, it's in the sdl2-sys bindings now, so it tries to link the symbol.
That said, this made me realize that the issue is Windows-specific, because the CI builds (which run on Ubuntu) are linking against SDL2 2.0.10 absolutely fine 🙂 I can live with that, because updating SDL2 is really easy on Windows (just have to drop the new files into the project).
My worry was that using new stuff would cause builds to stop linking on LTS versions of Ubuntu (which won't get new versions of SDL2 in their package manager), but that doesn't seem to be the case.
So TL;DR: we don't need to be afraid of using new SDL2 functions in Tetra 😄
Updates the requirements on sdl2 to permit the latest version.
Changelog
Sourced from sdl2's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)