search

17cupsofcoffee / tetra

🎮 A simple 2D game framework written in Rust
MIT License
907 stars 63 forks source link

Removes parameter 'P' from Shader::from_vertex_string and Shader::from_fragment_string #301

Closed LiquidityC closed 2 years ago

LiquidityC commented 2 years ago

Fixes: #300

17cupsofcoffee commented 2 years ago

Wow, this has been broken for two whole years and nobody's noticed 🤦 I think I created these methods by copying the Path versions and forgot to remove the generics. Good spot!

I'm honestly surprised Rust doesn't mark this as an error/warning like it does for unused generics on a struct.

This is technically a breaking change (as you could work around the issue by turbofishing the method with any random type), but I don't think anyone would complain if this was fixed in a patch release, so I'll merge this into main rather than 0.7.

17cupsofcoffee commented 2 years ago

Thank you :)