17cupsofcoffee / tetra

🎮 A simple 2D game framework written in Rust
MIT License
907 stars 63 forks source link

Integrate ImGui (imgui-rs) into Tetra as a early GUI solution (Fix issue #310) #311

Closed Nekomaru-PKU closed 2 years ago

Nekomaru-PKU commented 2 years ago

I've made my changes ready for being merged into the main branch. Example usages and other information can be found under https://github.com/17cupsofcoffee/tetra/issues/310

17cupsofcoffee commented 2 years ago

Hi - thank you for the effort you've put into this!

That being said, I don't think this is the sort of thing I'd want to merge into the main branch of Tetra, for a few reasons:

My recommendation would be to create an external library for this kind of integration, like egui-tetra did - I got halfway through doing something similar for imgui last year, but didn't have the time to finish it off.

Sorry for the disappointing reply, I really hate to turn down pull requests that have clearly had a lot of effort and thought put into them 😥