Closed Nekomaru-PKU closed 2 years ago
Hi - thank you for the effort you've put into this!
That being said, I don't think this is the sort of thing I'd want to merge into the main branch of Tetra, for a few reasons:
egui
out there, so this change feels like it's a bit too opinionated.imgui_glow_renderer
would work - Tetra's graphics backend code does a lot of GL state caching, and having an external library mess around with the OpenGL state could very easily break that.My recommendation would be to create an external library for this kind of integration, like egui-tetra
did - I got halfway through doing something similar for imgui last year, but didn't have the time to finish it off.
Sorry for the disappointing reply, I really hate to turn down pull requests that have clearly had a lot of effort and thought put into them 😥
I've made my changes ready for being merged into the main branch. Example usages and other information can be found under https://github.com/17cupsofcoffee/tetra/issues/310