search

1801BM1 / cpu11

Revengineered ancient PDP-11 CPUs, originals and clones
Other
155 stars 25 forks source link

Minor syntax fix VM2 PREFETCH #19

Closed xolod79 closed 3 months ago

xolod79 commented 8 months ago

I think we need to change blocking to non blocking statements.

-       bir_fix = (breg[14:12] != 3'o0)    // two ops instructions
+       bir_fix <= (breg[14:12] != 3'o0)    // two ops instructions

In these places: https://github.com/1801BM1/cpu11/blob/abe8b682a7de38f89865fcd4f57d9ba4d6d2256c/vm2/hdl/org/rtl/vm2_qbus.v#L1031 https://github.com/1801BM1/cpu11/blob/abe8b682a7de38f89865fcd4f57d9ba4d6d2256c/vm2/hdl/syn/rtl/vm2_qbus.v#L1025 https://github.com/1801BM1/cpu11/blob/abe8b682a7de38f89865fcd4f57d9ba4d6d2256c/vm2/hdl/wbc/rtl/vm2_wb.v#L730

xolod79 commented 3 months ago

Do you have any objection to this commit?

1801BM1 commented 3 months ago

Do you have any objection to this commit?

There is no any objections :) https://github.com/1801BM1/cpu11/commit/48be491dfcc1dfe9deb11f9ab4c74d43213f46ac

Thank you for the reporting